Closed lpalbou closed 3 years ago
https://github.com/geneontology/noctua-models/blob/dev/models/5900dc7400000468.ttl has modelState "delete"—it will not be loaded by Minerva at startup.
Great catch @balhoff !
Closing that ticket.
As a note however, it would still be nice to have a test during minerva/blazegraph launch: nb models without modelState "delete" == nb models available in blazegraph
@balhoff @lpalbou why are the models with delete modelstate not loaded at startup? We used to filter by delete modelstate. I thought they are loaded, but state can be changed i.e. from Delete back to Dev/Production. I think this would be great while waiting for a proper delete functionality on models
@tmushayahama I don't know. Ben added this feature but I'm not sure how the decision was made. It is easy to turn off if a different policy is decided.
Honestly I don't care much as I wouldn't even keep those models aside from the general GH versioning. They have been deleted for a reason and people are usually very conservative about that.
In a normal production environment I wouldn't let people search for models that have been deleted but I would make sure all the confirmation messages are here to avoid a deletion by mistake. In any case I support the fact they are not loaded nor searchable. There is a bunch of test models we simply don't even want to see anymore.
We were discussing Karen issue with title search: https://github.com/geneontology/noctua-annotation-review/issues/44 .
For reference, there are indeed two models with the PMID 27340223, both in the title and in the evidence fields:
Searching ty title query: http://barista-dev.berkeleybop.org/search//models?offset=0&limit=50&title=27340223&expand&debug Searching by mid query: http://barista-dev.berkeleybop.org/search//models?offset=0&limit=50&pmid=PMID:27340223&expand&debug
Only the 59c8885900000227 model can be found, not the 5900dc7400000468.
@tmushayahama had the idea it could come from models not being ingested back at minerva/blazegraph launch, and at first I agreed, but then I tested on what I believe is the RDF/SPARQL for dev: http://rdf-internal.berkeleybop.io/blazegraph/#query and I was able to find both models with a simple query:
=> does find http://model.geneontology.org/59c8885900000227
=> does find http://model.geneontology.org/5900dc7400000468
IF, http://rdf-internal.berkeleybop.io/blazegraph/#query is indeed the up to date RDF/SPARQL for dev, then the error is not in Minerva/blazegraph not ingesting models... IF it's not, bets are open, and it's either that or the Minerva API not working.
Action items:
@cmungall @kltm @balhoff as this may be a show stopper issue if that's in blazegraph ingest