geneontology / noctua

Graph-based modeling environment for biology, including prototype editor and services
http://noctua.geneontology.org/
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

Outage tasks for 2022-12-15 #807

Closed kltm closed 1 year ago

kltm commented 1 year ago
kltm commented 1 year ago

@vanaukenk The report is completed

vanaukenk commented 1 year ago

I've checked over the diff and most of the updates are okay and consistent with the work in these two ontology tickets: https://github.com/geneontology/go-ontology/issues/24152 https://github.com/geneontology/go-ontology/issues/24486

However, we also have two automatic model updates in which a BP term is being replaced by an MF term, as a result of the work in this ticket: https://github.com/geneontology/go-ontology/issues/24546

This update will result in either logically incorrect models or models with possibly incorrect biological information. The two models affected are: http://noctua.geneontology.org/editor/graph/gomodel:R-HSA-5221030 http://noctua.geneontology.org/editor/graph/gomodel:63894f2500001622

For the Reactome model, presumably this will be corrected with the next Reactome import, but for the second, mouse model, I think an MGI curator will need to review the model after the update to fix it.

I'm not sure how we should handle these types of replacements, i.e. MF for BP, in the future as they will likely result in similarly incorrect models.

@kltm @ukemi @cmungall @pgaudet @deustp01 @balhoff

kltm commented 1 year ago

@vanaukenk I think you might be thinking more of the day-to-day but, not to sound like a broken record, this would be in the scope of https://github.com/geneontology/project-management/issues/47. Theoretically, I assume that we'd go ahead with the breakages, but have fixing them be a high priority; larger changes would be shelved until there was enough resources to accomplish them. We would also be able to continuously run these checks against new versions of the ontology, so there would be more lead time and a way of testing changes.

vanaukenk commented 1 year ago

I think you might be thinking more of the day-to-day

@kltm I'm actually thinking more about the consequence of replacing a term from one ontology with another, i.e. BP with MF, and whether we should do that in the ontology or whether these types of changes should instead make use of the 'consider' tag.

kltm commented 1 year ago

@vanaukenk Is a main consequence under consideration that we'd be building up a body of "broken" (i.e. shex-illegal) models and what to do with them? Or is this purely a best practices for the ontology and how migrations operate? (If the latter, I'll hide this off-topic subthread.)

vanaukenk commented 1 year ago

@kltm and I talked about this.
We will go ahead with the model updates and alert the MGI curator to manually review the model post-update. We'd also like to talk this finding over with the ontology editors to see what they think is the best thing to do going forward.

pgaudet commented 1 year ago

I shouldnt have replaced a BP by a MF, I'll change that

vanaukenk commented 1 year ago

Thanks @pgaudet

ukemi commented 1 year ago

I went in and removed the mouse annotations.

vanaukenk commented 1 year ago

See also: https://github.com/geneontology/go-ontology/issues/24546#issuecomment-1353144829

deustp01 commented 1 year ago

For Reactome see comment in #26546

vanaukenk commented 1 year ago

@kltm - I'm closing this outage ticket in favor of any new work going into the next outage ticket #811