geneontology / noctua

Graph-based modeling environment for biology, including prototype editor and services
http://noctua.geneontology.org/
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

known_relations metadata should be 'provides input for' not 'directly provides input for' #825

Closed vanaukenk closed 1 year ago

vanaukenk commented 1 year ago

From the 2023-02-08 Geneva GO-CAM meeting:

@tmushayahama

Can you check all of the Noctua workbenches code to make sure that anywhere we use RO:0002413 the label is updated to 'provides input for' from 'directly provides input for'.

The current RO release no longer uses the 'directly' in the label.

Thanks and let me know if you have any questions.

vanaukenk commented 1 year ago

To test: http://noctua-dev.berkeleybop.org/editor/graph/gomodel:586fc17a00001662 http://noctua.geneontology.org/editor/graph/gomodel:586fc17a00001662

kltm commented 1 year ago

Notes: go-lego-react.owl looks fine over-the-wire (from minerva) looks fine

kltm commented 1 year ago

Okay, I think that the template for this is #805 and #804.

kltm commented 1 year ago

Now have + ontology-ui-overlay-data@0.0.2

kltm commented 1 year ago

@vanaukenk I have a possible fix in place on noctua-dev. If you could check it and it seems okay, we can role it out whenever on prod.

vanaukenk commented 1 year ago

@kltm I've checked existing models on noctua-dev and also added new 'provides input for' relations to test models and everything seems to be working and displaying fine. This can go to production whenever you're ready. Thank you!

kltm commented 1 year ago

@vanaukenk If it works for you, maybe let's just do this tomorrow during the outage?

vanaukenk commented 1 year ago

That works for me.

Thanks @kltm

vanaukenk commented 1 year ago

Checked the graph editor and the VPE again on production after the 2023-03-23 outage and all is working fine.