geneontology / noctua

Graph-based modeling environment for biology, including prototype editor and services
http://noctua.geneontology.org/
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

Status of models does not update on landing page #889

Open ValWood opened 1 month ago

ValWood commented 1 month ago

I am trying to flag my out-of-date models as "delete"

I have done this and saved,

But even after reloading, they still look like this on the landing page

Screenshot 2024-05-16 at 16 26 10

when I go back to the model they show as "delete"

Screenshot 2024-05-16 at 16 26 56
ValWood commented 1 month ago

I also changed titles but they didn't update either...

vanaukenk commented 1 month ago

@ValWood I checked the three models listed above and it looks like they are all empty, i.e. no individuals. I suspect that they're thus not being saved because we have a check in the system by which empty models are not saved. I'd have to check with @kltm about what's the best thing to do here to delete them.

kltm commented 1 month ago

I'd verify w/@balhoff, but I believe the function BeforeSaveModelValidator in ./minerva-server/src/main/java/org/geneontology/minerva/server/validation/BeforeSaveModelValidator.java handles this logic. My read of it is, to save, you need:

I don't think that "emptying" a model was ever a considered workflow. Odd that they managed to get saved in the first place; we could add something at some point to sweep those out.