geneontology / noctua

Graph-based modeling environment for biology, including prototype editor and services
http://noctua.geneontology.org/
BSD 3-Clause "New" or "Revised" License
38 stars 12 forks source link

annotate a MF activity unit on a specific sub-part of a complex #901

Open ValWood opened 4 months ago

ValWood commented 4 months ago

We would like to be able to annotate a MF activity unit on a specific sub-part of a complex

(discussed with @vanaukenk , but I don't think there is a ticket for this)

ValWood commented 3 months ago

This illustrates how we want to capture these. Sometimes we have a large complex , but we want to put the activity on a single subunit but still have it represented as part of the complex:

how we want to annotate complexes

(not this is a fude because thee is now relationship on the arrow)

ValWood commented 3 months ago

As an aside, I'm not sure that this is really "positive regulation" it's definitely "positively affects", but I think the labels on the arrows are sometimes misleading. @vanaukenk what would you use in this context?

thomaspd commented 2 months ago

The current guidelines are to associate the function with the complex only if it's an "emergent" function that can't be ascribed to a single gene product, which doesn't seem to be the case here, at least to some degree of approximation. I think it's best for users if we can associate functions with individual gene products whenever possible. If you want to say that ndc80 is in this complex when it's active, there's been a proposal to allow occurs_in (protein complex GO term) to be added to the current spec, in addition to allowing location to be specified by cellular anatomical entity and cell type. Would that work for this case?

ValWood commented 2 months ago

Well its that old problem of "molecular machines" I guess.

I think these complexes do have "emergent functions, but we haven't figured out how to describe them. How do we describe this in GO? lateral attachemnt kinetochore-splindle

microtubule kinetochore attachment

We have activities annotated to specific subunits (because this is the nature of the experimental data and we don't want to lose that detail) but i) we still want to represent all of the complex members in the model

For example ndc80 is the adaptor for mph1 and alp7 based on experiment, but clearly the entire complex contributes to the function and we don't want to leave other subunits out of the model or it will be incomplete.

We are left with 2 options 1, use a complex and lose the individual subunits This would lose the experimental detail

  1. Add the individual subunits but not grouped as a complex (this will look incredibly messy for kinetochore pathways in the go-cam-viz)
ValWood commented 2 months ago

We haven't modelled the kinetochore pathways yet because we are waiting on the complex import issues.

But we find similar in the various heterochromatin pathway modelling:

See for example: http://noctua.geneontology.org/workbench/noctua-visual-pathway-editor/?barista_token=sasgrjd2nx44ugmbfn3w&model_id=gomodel:665912ed00000652

The go-cam viz looks like this :

Screenshot 2024-09-06 at 17 33 41

(Note that not all components are rendering correctly, some connections are missing)

This is really a display issue, rather than a curation issue. It is hard for users to to navigate but would look much better if we could group activities by complex in the viewer. It would make much more biological sense. Especially as these pathways become increasingly complicated.

Screenshot 2024-09-06 at 17 30 32

(note that each complex subunit usually has its own annotation, in addition to being part of the complex, which could be described as having an emergent function like "chromatin remodelled")

thomaspd commented 2 months ago

Yes, it's a tough call on when to use the complex as the functional unit. Judging from the Fig 4b above, you can't assign the dam1/dash adaptor activity to just ndc80 since it seems to also depend on nuf2. So it seems like you could subdivide the complex into two distinct complexes, ndc80/nuf2 (dam1/dash to spc24/25 adaptor) and spc24/25 (ndc80 to mind adaptor). But since these two components ndc80/nuf2 and spc24/25 appear to always be in a larger complex together, and both are required for the overall activity, it seems to make sense to me to make the entire ndc80 complex a functional unit. If you want, we can include the details of what each subunit does, in the definition of the ndc80 complex GO term.

ValWood commented 2 months ago

That wouldn't work in the heterochromatin example above though....and we would lose a lot of detail that we would want to include in the model. i.e the annotations are on the individual subunits. Sometimes these capture complex modification dependencies etc.

We could just lump activities onto the complex but then we could not reuse existing annotations (which we really want to do),

For example CLRC (image above) has 3 adaptors, a UB ligase and a methyltransferase , and a subunit of unknown function. RITs (image above) have an endonuclease and a histone reader. These pathway are going to be very difficult to navigate, and harder for users to understand unless we can organize by complex in the viewer. The user experience would be much better if we represented the complex in the graphviz, and the user could use the "expand protein complexes" button to see the activities attached to the individual subunits.

thomaspd commented 2 months ago

The chromatin remodeling complexes sound like they're pretty modular-- each subunit has a distinct activity and we should try to describe the causal relations between those activities in the GO-CAM. The discussions we've been having with Colin about chromatin remodelling have been helpful, and you should attend the next one. @pgaudet can you please make sure Val is invited to our next discussion with Colin?

ValWood commented 2 months ago

We have described the individual activities (you can see them in the model above). It's just hard, even for an expert to consume the information in the display without grouping by complex (because this is how they think about, and draw, the pathways.

Actully @PCarme did our chromatin remodelling pathways and he is pretty expert in this (and pombe probably has the most detail in this area)

The pathway above is centromeric chromatin remodelling, and we also have mating type region and subtelomeric, the pathways are slightly differnt.

ValWood commented 2 months ago

I was attending the Chromatin calls until relatively recently but I had to drop off because too much on. I can try to attend on Friday but it depends if I am finished up with other stuff before my hol the week after and next week is already pretty rammed with meetings. Pascal could join but he is also away next week. Maybe we can start to attend after holidays PAscal is back before me so if you could CC him he could probably attend.