search

geneontology / obographs

Basic and Advanced OBO Graphs: specification and reference implementation
63 stars 12 forks source link

EquivalentNodesSet.representativeNodeId() is not used in production code #61

Open julesjacobsen opened 4 years ago

julesjacobsen commented 4 years ago

EquivalentNodesSet.representativeNodeId() is used in the unit test, but never set in the production code. The EquivalentNodesSet is only used in FromOwl:

https://github.com/geneontology/obographs/blob/f56ec1458f11e5af5b3b59581f3f4f0d24d9853a/src/main/java/org/geneontology/obographs/owlapi/FromOwl.java#L236-L239

Is this method really required as a setter? Seems it could be a default method to just choose the first if never set.

cmungall commented 1 year ago

perhaps we could even remove this from the schema?