geneontology / pathways2GO

Code for converting between BioPAX pathways and Gene Ontology Causal Activity Models (GO-CAM)
8 stars 0 forks source link

Change the representation of regulatory reactions to use 'has_small_molecule_regulator' activity #204

Closed ukemi closed 1 year ago

ukemi commented 2 years ago

Currently when we import a regulatory reaction from Reactome, we create a construct where the entity that enables the regulated reaction (RMF) binds the regulator and the binding MF regulates the RMF. We also create a process that the binding is part of to infer the regulatory process. A simple example of this can be seen in the 'Fructose catabolism' pathway. http://noctua.geneontology.org/editor/graph/gomodel:R-HSA-70350 https://reactome.org/PathwayBrowser/#/R-HSA-70350

In this pathway, the KHK enzyme enables ketohexokinase activity that is activated by K+ and is inhibited by ADP.

deustp01 commented 2 years ago

Defer from action in connection with GO-CAM build from Reactome ver 82 - do it later

ukemi commented 1 year ago

Checked:

ukemi commented 1 year ago

Shex failures, at least some of them are due to this: https://github.com/geneontology/go-shapes/issues/299

ukemi commented 1 year ago

@dustine32 was this only done for the import or for all the existing models? I notice that the ticket seems to include a retrofit.

ukemi commented 1 year ago

In this pathway, R-HSA-204174 the controller RXRA:PPARD:atRA (R-HSA-5634107_R-HSA-203946_controller) is now missing any relation to R-HSA-203946. It positively regulates it. It doesn't get the relation because it is not a small molecule. Is there a way that when a controller is a protein complex (has part some protein or set of proteins) we could infer 'enzyme activator/inhibitor activity' enabled by the complex or protein?

dustine32 commented 1 year ago

Orphan glutathione should not even be in model R-HSA-204174. It was part of a drug rxn that was filtered out.

ukemi commented 1 year ago

On the June 19, 2023 'weeds' call, we made the decision to go ahead and allow the drug identifiers that are sneaking in in this load. In the future, the drugs will be tagged explicitly in the BioPax file and will be filtered in that manner rather than by identifier space. ping @deustp01 @dustine32

ukemi commented 1 year ago

On the June 19, 2023 'weeds' call, we decided to allow the reactions that are upstream or downstream of the main pathway to maintain the 'old'/incomplete representation of regulators. Even though this is not ideal, it puts more of the model in alignment with GO-CAM standard practice. In the future we will get feedback from the larger community about whether linking models will be done in a timely manner and if so, we will not need to represent these in the models the way they are currently represented. If the larger community does not solve this problem in a timely manner, then we will solve this problem specifically for the imports. ping @deustp01 @dustine32