geneontology / pipeline

Declarative pipeline for the Gene Ontology.
https://build.geneontology.org/job/geneontology/job/pipeline/
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Task list and timing to complete MGI import #275

Closed ukemi closed 2 years ago

ukemi commented 2 years ago

ping @loricorbani

dustine32 commented 2 years ago

@ukemi Beautiful ticket! Just FYI, I'm currently working on step 1b.

kltm commented 2 years ago

@loricorbani @ukemi Clarifying for 1d and 1e that we do not use GPADs for pipeline ingest and will need GAFs.

kltm commented 2 years ago

@loricorbani @ukemi For 1e, I believe we discussed that these would be at a publicly available location and not files through email. (As well as GAF formatting.)

kltm commented 2 years ago

@loricorbani @ukemi For 8, there is currently some time travel. What should the correct date be there? Please feel free to correct directly in the list at the top.

kltm commented 2 years ago

@loricorbani @ukemi For 11, I'm not sure why there are files listed here?

dustine32 commented 2 years ago

@loricorbani Step 1c is complete and the output GPAD files are now available in the skyhook/issue-238-wormbase-test-pipeline location.

leemdi commented 2 years ago

1d/1e files are here: http://www.informatics.jax.org/downloads/custom/noctua/ gene_association.mgi gene_association_nonoctua.mgi gene_association_pro.mgi mgi.gpad mgi.gpi mgi_nonoctua.gpad

The "nonnoctua" files are those that contain no Noctua annotations and no PAINT annotations. that is, the Annotations MGI loads from GOA/Human, GOA/Mouse, Rat, etc.

fyi, GO:0007569 failed because it was recently obsoleted but was in noctua_mgi.gpad file. Let me know if you want to send me a new file or just continue with this test.

ukemi commented 2 years ago

11 must have been a weird cut and paste error from my transfer of Lori's ticket. Dustin needs to produce the files that Lori will pick up for our production load.

dustine32 commented 2 years ago

Thanks @loricorbani! The new custom/noctua folder should work great. Question: is gene_association_nonoctua.mgi simply the GAF version of mgi_nonoctua.gpad? If yes, then awesome, as GAF is the format we'll need for that file when we run the GO pipeline after the MGI import into Noctua.

On obsolete term GO:0007569, this is very weird. I couldn't find this term in the noctua_mgi.gpad file hosted at http://skyhook.berkeleybop.org/issue-238-wormbase-test-pipeline/products/annotations/noctua_mgi.gpad.gz as of 2022-03-03 7:30AM Pacific. Are you using an older version of this file perhaps?

leemdi commented 2 years ago

Dustin,

Ok, let’s try again…new files are available here:

http://www.informatics.jax.org/downloads/custom/noctua/

Lori

dustine32 commented 2 years ago

@loricorbani Rad! No validation errors on my end. I'm producing the new models now (step 1f) and will let you know when the new GPAD files are available on skyhook (after step 1g is complete, likely late, late tonight or early tomorrow Friday).

sierra-moxon commented 2 years ago

https://github.com/sierra-moxon/mgi_import_qc/tree/main/03_02_2022 - diffs for file2 and file4 look pretty good. :)

ukemi commented 2 years ago

Wow! This is awesome. The changes that @balhoff made to the GPAD output must have gotten rid of the regulates differences.

dustine32 commented 2 years ago

Noting where we're at:

leemdi commented 2 years ago

I am at Step 3 - reload of MGI test using Dustin's Step 2 file

ukemi commented 2 years ago

Great! So now we have two parallel tasks occurring. @ukemi will begin the training session with the MGI curators today using dev as the workspace. @loricorbani will reload MGI and push things all the way through so @ukemi can check the MGI web display of GO annotations in a testing environment. The checking may take a few days because I suspect I will be occupied with the training.

leemdi commented 2 years ago

step 3 : done; ready for David to review: MGI Test Server

leemdi commented 2 years ago

step 8 Mar 11 : Lori: install new PWI tag on MGI Production : done MGI editing interface (PWI), GO Annotations is read-only. MGI curators must use Noctua for all GO Annotations.