geneontology / pipeline

Declarative pipeline for the Gene Ontology.
https://build.geneontology.org/job/geneontology/job/pipeline/
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

Remove remaining ROBOT from non-dockerized portions of the pipeline #284

Open kltm opened 2 years ago

kltm commented 2 years ago

Due to recent changes in upstreams (https://github.com/ontodev/robot/pull/934, https://github.com/ontodev/robot/issues/997) ROBOT can no longer build naturally on the home machine for the GO pipeline (required Java version to 11).

Basically, the remaining undockerized use of ROBOT is this silly section here: https://github.com/geneontology/pipeline/blob/master/Jenkinsfile#L792-L809

Producing: ~metadata/groups.tmp.jsonld~ ~metadata/users.tmp.jsonld~ metadata/groups.ttl metadata/users.ttl

Tagging @balhoff ; would users.ttl/groups.ttl be better produced elsewhere or by a different method?

As a (permanent?) workaround for this, we can try locking to an older version.

kltm commented 2 years ago

Okay, after waaay too long trying to figure out how to pin to a branch or hash in github so I can just have the version I want, I've done something very very hacky just so I can move on and test something today without starting a mini-refactor. I've forked robot to a personal robot-old and pushed it back to where I want it:

 2055  git clone https://github.com/kltm/robot-old.git
 2058  cd robot-old/
 2063  git reset --hard 55efde92
 2066  git push -f origin master
kltm commented 2 years ago

Finally got something to limp forward with.

balhoff commented 2 years ago

Why not download a release? https://github.com/ontodev/robot/releases

kltm commented 2 years ago

That's definitely an option as well, but would have meant that I'd have to start fussing with a bit more that just that one stanza (and I wanted to move ahead quickly as it was blocking more "critical" work). I think probably the "right" thing to do is to either eliminate the need for ROBOT there (by adding it to the right ontology build area, if that's what it's being used for) and/or to split it out and dockerize it.

kltm commented 2 years ago

Talking with @balhoff on the call today, he is going to tak a look at moving the build (and use) of these ontologies into go-ontology proper https://github.com/geneontology/go-ontology/issues/23276.