geneontology / pipeline

Declarative pipeline for the Gene Ontology.
https://build.geneontology.org/job/geneontology/job/pipeline/
BSD 3-Clause "New" or "Revised" License
5 stars 5 forks source link

In some cases, the ontology build gets dirty and uses old artifacts during build #311

Closed kltm closed 1 year ago

kltm commented 1 year ago

We seems to be having some reoccurring issue where the ontology build will get stuck and apparently reuse bad imports or other files that seems to gum up the build works. Clearing workspaces out manually seems to work for this, but we need something automatic.

We could either have a clean command or find a manual way to clear the workspace--the current workspace cleaning build into Jenkins and explicitly called in the pipeline does not seem to be sufficient.

Tagging @balhoff

kltm commented 1 year ago

Will try adding additional directory removal into the pipeline.

kltm commented 1 year ago

@balhoff Hm, this is actually going to cause some issues as the items created in the docker image are getting out into the workspace, creating some permission oddities. I can probably finesse this by disappearing the whole thing into a tmpfs (like we do elsewhere), but it would mean that we'd having nothing to inspect on the filesystem if we wanted to do after-the-fact triage of issues (like we have elsewhere). Before heading down that path, how hard would it be to have a thorough clean command in the ontology build?

balhoff commented 1 year ago

@kltm can you try running this?

git clean -fx

kltm commented 1 year ago

Okay, the way this is working in Jenkins, I do not seem to be able to bypass some kind of cleanup before the steps in a stage start. This means that once we're in a weird state, no attempts at clean before build can operate before we hit a failure. With this, we basically lose any hope of preserving artifacts as a standard practice. That said, I'm going to try and add cleaning at the end; at least with this we could easily temporarily turn it off for debugging if needed, rather than relegating everything to a disappearing tmpfs.

Testing with this continuing.

kltm commented 1 year ago

From the logs, the "post" cleaning seems to be doing the trick. I think this can be propagated out and regarded as "done" until there is evidence otherwise.