Closed mugitty closed 7 months ago
@mugitty Change here is to rsync
a aggregate-rule-violation-report.md
file but where is this file generated? I don't see the command to generate in the Jenkinsfile. Does this line need to be updated too?
https://github.com/geneontology/pipeline/blob/995bd712499a38a3bb7180578016461500bef1e0/Jenkinsfile#L762
aggregate-rule-violation-report.md is an additional file that is generated by combined_assigned_by.py
@mugitty Oh I see. Filename aggregate-rule-violation-report.md
is hard-coded in combined_assigned_by.py
.
This works but it might be nicer to parameterize that new output filename so that it's explicitly mentioned in the Jenkinsfile
. I'll let @kltm decide whether that's really required.
When is the file going to start being produced and how? I want to make sure there is no lag so that rsync
does not/cannot fail here. Ideally, the file would be produced and in the branches before the move itself was updated.
@kltm , It is already being produced in https://build.geneontology.org/job/geneontology/job/pipeline/job/issue-go-site-2093-metadata/ https://github.com/geneontology/go-site/pull/2207#issuecomment-1841635784 has to go in first.
@mugitty it's not being produced on master
, snapshot
, or release
, which are the ones I care about here. A mismatch would cause pipeline failure.
@kltm , I will update on master
@mugitty To clarify, the go-site
merge needs to happen before the pipeline
merge.
Note, this PR is associated with https://github.com/geneontology/go-site/pull/2207