Open dustine32 opened 4 years ago
Actually, this format's way more readable:
-
MECHANISM: acetylation
MI_ID: MI:0192
GO_ID: GO:0016407
RELATION: RO:0002304
-
MECHANISM: binding
MI_ID: MI:0915
GO_ID: GO:0005515
RELATION: RO:0002629
@dustine32 Why is there a 'relation' mapped for each mechanism? It is not a one-to-one mapping, right? (i.e, one mechanism can have different type of causal relation) or does 'relation' refers to something else? Thanks
@vtoure Right, the relation column shouldn't be 1:1 for mechanisms. I just quickly added those examples for the ticket. @thomaspd was going to add a relation column to the paper table but I'm actually not sure what the values will look like. I could see the cardinality being zero-to-many with zero just meaning use the existing default causal relation logic we've already coded.
This probably relates to some of the paper doc comments:
has_output
for "up-regulates" or has_input
for "down-regulates" for the relation connecting the downstream, regulated activity with its small molecule entity.Currently, this RELATION
field is just sitting in the new YAML file, being ignored by the conversion code. We can wait to see what @thomaspd has in mind for this field and then design accordingly?
Make a parsable YAML file for maintaining the mappings between SIGNOR mechanisms and GO terms:
This will move the mappings out of
pathway_connections.py
, where they are currently hard-coded:The code should simplify to something like:
Also adding a "relation" field for each mapping. Note the example relation assignments above are made up by me. I believe @thomaspd will be adding this field to the same table in the paper so I can just populate from that.