search

geneontology / termgenie

Web-application for pattern-based ontology class generation
7 stars 6 forks source link

setting things using the guid (github user id) to fix #102 #104

Closed nathandunn closed 7 years ago

nathandunn commented 7 years ago

@cmungall and @kltm Let me know if this makes sense in context of #102 and @cmungall comments. I'll update the server if so.

kltm commented 7 years ago

@nathandunn I would note that the uri is not necessarily an ORCID, it could also be an GO ref like GOC:kltm.

nathandunn commented 7 years ago

@kltm Right, I just copied it from here:

https://github.com/geneontology/termgenie/pull/104/files#diff-0e1d3d9eaf1a60f410bb6ea14b9ff66eL84

cmungall commented 7 years ago

To be honest I'm not familiar enough to properly review this. I'm not familiar with Guid. It seems we could do more documentation mapping the semantics of the fields in users.yaml, TG and obo/owl properties.

But given things are non-functional as-is, let's go the empirical approach. Merging.

nathandunn commented 7 years ago

To be honest I'm not familiar enough to properly review this. I'm not familiar with Guid. It seems we could do more documentation mapping the semantics of the fields in users.yaml, TG and obo/owl properties.

@cmungall @kltm That makes 3 of us. Definitely empirical. I'll start updating now.