should work to fix #105 by always returning a valid looking email

geneontology / termgenie

Web-application for pattern-based ontology class generation

7 stars 6 forks source link

Closed nathandunn closed 7 years ago

nathandunn commented 7 years ago

@cmungall and @kltm can you take a look. This is based on @kltm comment.

nathandunn commented 7 years ago

Actually looking here, I think that it is an in-memory constraint only: http://stackoverflow.com/a/2899828/1739366

So, I moved the constraint up.

kltm commented 7 years ago

Is this PR currently ready for review and merge?

kltm commented 7 years ago

Honestly, in this interface, I'm not understanding how there are your three separate commits, but only "1" file changed...

nathandunn commented 7 years ago

@kltm It is ready. The 3rd commit was a merge from upstream, which had no effect.

kltm commented 7 years ago

roll the dice!