Remove Bootstrap dependency

pkalita-lbl commented 1 year ago

Fixes #16

Summary of changes

Bootstrap dependency is removed and any necessary style definitions have been added/updated in our own stylesheets. In particular Bootstrap's card component was used somewhat extensively. This has been replaced by a panel (and related) class defined in src/scss/_panel.scss.
A new go-loading-spinner component has been added. This was previously defined within the wc-gocam-viz component, but it seemed cleaner to extract it into a standalone component.
All components now use the shadow DOM.
Various CSS classes with no existing style rules have been removed from elements.
Fixed a bug in the wc-gocam-panel component where updating the repository didn't actually refetch the GOCAM data -- not strictly related to any of the other changes but it made testing easier.

Caveats

These changes aren't pixel-level identical with the latest released version. I did my best to imitate the existing style, but I did make some simplifications here and there where I felt it made sense. Compare:
I did not make an attempt to harmonize the CSS class names representing all the parts of each component. I see that as part of the work of #17.
The wc-gocam-viz component previously used the Bootstrap container class at the top-level which limited how wide the component could be. I see this as the responsibility of the hosting page to determine, not the component itself. So now the component will be as wide as whatever container the user puts it in.

kltm commented 1 year ago

Part of https://github.com/geneontology/wc-gocam-viz/issues/16 ? Looks good to me; will defer to @tmushayahama to look at and merge.

pkalita-lbl commented 1 year ago

Oops, yes. Will update the description.

kltm commented 1 year ago

Sorry, didn't mean to nudge, just fiddling with the paperclips.

tmushayahama commented 1 year ago

@pkalita-lbl @kltm This looks really great, far more superior and cleaner than the previous. Thanks

Maybe a tiny thing, but lets merge it first. we should prefix all ex-bootstrap name clashes items with "gocam-" like .panel, .panel-header in case our host has bootstrap

one more test, I couldn't tell if it was there in the previous is the indentation of the nested nodes i.e

part of A --part of B

tmushayahama commented 1 year ago

@pkalita-lbl @kltm. Just to add tested on a much model and good

kltm commented 1 year ago

@tmushayahama Cheers!

geneontology / wc-gocam-viz

Remove Bootstrap dependency #23

Summary of changes

Caveats