search

geneontology / wc-gocam-viz

Web component to visualize GO-CAMs
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Add "has_input" and "has_output" relation symbols to legend #34

Open dustine32 opened 7 months ago

dustine32 commented 7 months ago

In this GO-CAM model for Mouse Itpr1, the has_input and has_output relations (circled) are not shown in the legend, making their meaning ambiguous to the viewer: image

We should add these two relation symbols to the legend.

Reported by Paul Sternberg and @thomaspd. Tagging @tmushayahama and @kltm to determine who should make the code change.

kltm commented 7 months ago

@pgaudet bundling this into AGR project, as noticed by PI.

kltm commented 7 months ago

@dustine32 I'm not sure who is most familiar with the codebase at this point. I'm guessing this is a small change? I'm guessing that @dustine32 @tmushayahama or @pkalita-lbl would be able to quickfix, but I'm not sure who has this in their head the most. I'll ask on slack.

tmushayahama commented 7 months ago

This is already working up-to-date on the web-component, I don't know what version of the component the agr-ui is using. As you can see from the workbench example, the legend shows the has_output and has_input. So might be a simple version bump on the agr-ui site

image

the url is this http://noctua-dev.berkeleybop.org/workbench/noctua-alliance-pathway-preview/?model_id=gomodel%3A61f34dd300001044

tagging @kltm @pkalita-lbl @dustine32

dustine32 commented 7 months ago

Sorry @tmushayahama for making you dig into something that should have been obvious to me! You're right. The latest geneontology/wc-gocam-viz npm version is 1.0.0 and agr_ui is currently on 0.0.51.

kltm commented 7 months ago

Okay, so what is the action here? If this "works" in our version, is the action to make a ticket on the AGR tracker?

dustine32 commented 7 months ago

@kltm Yup! Just created: https://github.com/alliance-genome/agr_ui/issues/1272

kltm commented 7 months ago

Cheers! Closing out here.

vanaukenk commented 6 months ago

Hi - re-opening this ticket as it came up in discussion on the Swiss-Prot GO-CAM call today. @tmushayahama - let's touch base about this at the end of today's workbenches call.

kltm commented 3 weeks ago

@tmushayahama @vanaukenk I see this in the "Done" category, but is "Open". What is the current state here?

Also, does this have any relation to the items here https://github.com/orgs/geneontology/projects/160/views/1 ?