Open dustine32 opened 1 year ago
@dustine32 @tmushayahama Could you link the branch?
Or setup a PR so we can see the code/link changes? <-- preferred
@kltm Ah crud, you're right. Sorry! The branch is creatively named "dev": https://github.com/geneontology/web-gocam/commits/dev
I just realized there were a lot of formatting changes that clutter the changes relevant to this ticket (noctuaAlliancePathwayViewUrl
env var, getAlliancePathwayView
function, hook function into browse-models.component.html
). I also need to remove the URL change to point back to the regular go-public endpoint for fetching the JSON files. Thinking of just copying the relevant changes to a new branch and PR.
No worries, sometimes things get confused. Operationally, the change would be:
noctuaAlliancePathwayViewUrl: 'http://noctua.geneontology.org/workbench/noctua-alliance-pathway-preview/?model_id=',
noctuaPathwayViewUrl: "http://noctua.geneontology.org/workbench/pathwayview/?model_id=",
?
My understanding is that we wanted to have this be an embedded widget in the /go-cam site and not have traffic heading towards the curation system.
Correct on both @kltm. I think (@thomaspd may want to weigh in) this is a short-term fix to at least direct users to a more digestible graph. The full widget embedding could be handled in a new ticket?
I think the question here is if this is a "project" or not. If @thomaspd and @pgaudet agree, I'm more than happy to take this as a software maintenance ticket, but we do need to track both of these.
Yes, this would be fine as a maintenance ticket. I think we're all in agreement that the public GO-CAM site should not point to our curation tool, and it's important to provide a visualization of these GO-CAMs so our users can understand what each of them represents.
@thomaspd I think the technical point that I miscommunicated is that this is still pointing to our curation tool and creating system traffic, load, and hinting bots. I agree that this is an improvement (getting rid of the login button if nothing else), but I still think we need to prioritized the "stronger" version of this much sooner than later.
@tmushayahama Believes that the stronger version of this--having the widget open on click--is quite easy, so we will take a look at that path first.
@tmushayahama can fill in the details but we discussed (with @thomaspd) that there is some Angular version issue that makes implementing the "on click widget open" much more difficult than expected. So, for a short-term fix, I can PR this change https://github.com/geneontology/web-gocam/commit/f648a8725429ec9ae5fd55da67ddf26a301e3fe1 and deploy.
@tmushayahama @dustine32 Yes, it would be good to get the details here for review.
Pulling this out of project for keeping traffic away from curation interfaces.
Title explains (most of) it all:
This View button should go to:
Not to the Noctua editorial interface.
@tmushayahama already has the code change in a branch. I can merge the change and deploy to AWS.
Tagging @thomaspd @kltm