ported to stable - Githubissues

generalelectrix / rust-osc

Library for sending and receiving OSC 1.0 streams over UDP.

24 stars 4 forks source link

ported to stable #11

Closed hoodie closed 8 years ago

hoodie commented 8 years ago

Hey, I played with this library a little and accidentally ported it to stable (v1.6). Tests seem to pass.

removed redundant attributes to stable features
ported to stable rust ( getting by without unstable features )

generalelectrix commented 8 years ago

Awesome! Would you mind adding an update to the readme with some details to the update and which Rust release it was tested against? Then I'd be happy to integrate this PR.

So glad to see people making use of this library, I've been away from Rust for a while but it is still a candidate in my mind for future development for art projects.

hoodie commented 8 years ago

I have to admit, I actually haven't done much with it yet, I'm still thinking about replacing py_osc, but for now I was happy with the task of making this work. I tested on >= 1.6.0. I hope the tests are sufficient, more I didn't do yet. But it looks like, if you heed @mitchmindtree's advice, you could even put this up on crates.io

generalelectrix commented 8 years ago

I'll go ahead and merge this, thanks for the contribution!

hoodie commented 8 years ago

Sorry, I got distracted there for a minute, ... or eleven days :D Thanks for merging, I actually have some other commits, that you might like too.