search

generalov / open-in-editor-vscode

Open in Editor extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=generalov.open-in-editor-vscode#review-details
MIT License
7 stars 6 forks source link

Auto close Terminal & iTerm2 support #2

Open iamwrm opened 7 years ago

iamwrm commented 7 years ago

Every time I use the extension, it will leave me with a terminal.app with the shell command I used. When using it for multiple times, it will leave a lot of windows, which are annoying.

Also, can the user change the default terminal app to iTerm2?

my OS: macOS Sierra

generalov commented 7 years ago

Hi @iamwrm, thanks, it's cool idea. Suddenly, I do not have any device with macOS. Could you please provide me with some ideas how to launch the terminal on macOS? And PR will be better. :)

iamwrm commented 7 years ago

@generalov Thanks for response. Now I think that if the extension can auto close the terminal or just show the output like what the vscode build-in tasks do, that would better and it doesn't matter which terminal app you use. The feature of allowing the user to select one of the configured editor is more important now. I don't really have the ability to create PR right now. I need time to go over Typescript syntax.