search

generativefm / generative.fm

A platform for playing generative music in the browser.
https://generative.fm
MIT License
1.59k stars 86 forks source link

Volume scroll wheel preventDefault ignored due to passive setting #82

Closed alexbainter closed 5 years ago

alexbainter commented 5 years ago

The event handler for the wheel event when the mouse is over the volume wheel calls preventDefault() to stop scroll behavior when a user rolls the mouse wheel while the pointer is over the volume control (as this should adjust the volume instead). As of v0.12.0, the following message is logged in Chrome: 

index.jsx:6 [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/6662647093133312

See https://github.com/sahel-sh/Document-level-passive-wheel-event-listeners/blob/master/Explainer.md

Fix should be easy, just pass passive: false when registering the wheel event listener.

alexbainter commented 5 years ago

Resolved in #83