search

generic-github-user / Star

A website where anyone can rate anything.
0 stars 1 forks source link

Added new-post.css to separate out the css for new post pop-up #67

Closed vasujogani closed 6 years ago

vasujogani commented 6 years ago

Hey! This is an interesting beginners project that could give a lot of experience. One thing I would suggest that you should before turning this into a big scale project is look into components for designing. That would make it extremely easy for you to manage your code for UI/UX. Also add more directories to structure your code better (this style is now a little retro now). Let me know where you are in the project and what you are struggling with. I might be able to provide you some insight. Thanks! keep it up

generic-github-user commented 6 years ago

As the first pull request on one of my projects, this contribution means a lot to me. I will definitely look into your suggestions regarding UI components and file organization. This project has been a learning experience for me, as I'm definitely no expert at web design. My CSS is extremely messy and inefficient as of right now (there is an issue open regarding this), as I have mainly been focusing on adding the main features and functionalities to the app.

I am currently working on a post sharing update, which is almost complete, and I will be happy to approve your pull request as soon as I push this commit (this should be either tonight or tomorrow). An operational testing version should be available by September 15th, and I would definitely appreciate your feedback!

generic-github-user commented 6 years ago

I've added the commit. Thank you for your help! I will be cleaning up the CSS over the next couple of weeks and separating it into a few different files, as I have done for the JavaScript.