search

genericworkflownodes / GenericKnimeNodes

Base package for GenericKnimeNodes
https://github.com/genericworkflownodes/GenericKnimeNodes
Other
15 stars 16 forks source link

Changes to remove deprecated code as of KNIME 3.0 #114

Closed chahuistle closed 8 years ago

jpfeuffer commented 8 years ago

What's the status here?

chahuistle commented 8 years ago

I think all needed changes to remove deprecated code have been made.

On Thu, Feb 4, 2016 at 12:32 PM jpfeuffer notifications@github.com wrote:

What's the status here?

— Reply to this email directly or view it on GitHub https://github.com/genericworkflownodes/GenericKnimeNodes/pull/114#issuecomment-179782546 .

jpfeuffer commented 8 years ago

Ok. So is it ready to merge? Or do you mean these changes have been merged in other PRs already? You are the boss here ;)

chahuistle commented 8 years ago

Sorry... It's ready to merge... I think I already made a pull request for it.

On Fri, Feb 5, 2016 at 10:50 AM jpfeuffer notifications@github.com wrote:

Ok. So is it ready to merge? Or do you mean these changes have been merged in other PRs already?

— Reply to this email directly or view it on GitHub https://github.com/genericworkflownodes/GenericKnimeNodes/pull/114#issuecomment-180276384 .

jpfeuffer commented 8 years ago

The one we are currenlty commenting in?

chahuistle commented 8 years ago

Ah... I was using the "Reply to this email" feature directly... Yeah, this one right here!

On Fri, Feb 5, 2016 at 10:55 AM jpfeuffer notifications@github.com wrote:

The one we are currenlty commenting in?

— Reply to this email directly or view it on GitHub https://github.com/genericworkflownodes/GenericKnimeNodes/pull/114#issuecomment-180278258 .

jpfeuffer commented 8 years ago

Changes merged via the 3.1 branch