search

genericworkflownodes / GenericKnimeNodes

Base package for GenericKnimeNodes
https://github.com/genericworkflownodes/GenericKnimeNodes
Other
15 stars 16 forks source link

FileMerger only merges first files of every port #139

Closed jpfeuffer closed 7 years ago

jpfeuffer commented 8 years ago

I saw that the relatively new filemerger node from me an Alex does only merge the first URI from every merged port. That comes from the fact that we use the functionality of creating a FileStoreReferenceURIPortObject which seems to limit to only the first URI. Question: Can this class be extended or should one find an alternative solution. I was struggling on how to allow both Abstractfilestoreportobjects from e.g. a ZiploopEnd as well as the usual URIPortObjects. In general, I still did not get the complete difference between them. I guess this is a minor issue and don't know if we even should support it.

jpfeuffer commented 7 years ago

Okay, preparing a fix. The reason was that a FileStoreReferenceURIPortObject could not be used to create a new one and was I think only designed for a single file (to collect loop results).

jpfeuffer commented 7 years ago

Solved in #151