search

genericworkflownodes / GenericKnimeNodes

Base package for GenericKnimeNodes
https://github.com/genericworkflownodes/GenericKnimeNodes
Other
15 stars 16 forks source link

Overwriting files from URIPortObjects with same name but e.g. different FileStore #149

Open jpfeuffer opened 7 years ago

jpfeuffer commented 7 years ago

Let's say you use two FileFilters on the same input in a ZipLoop with different settings and put them in the same Output Folder, the Output Folder node will silently overwrite files with the same filename (despite being located in different temporary FileStores). Definitely we need to give a warning. In most cases it can be circumvented by giving different output folders but if you use the FileMerger that appends lists of FileStores/URIs this is not possible. FileMerger seems to be useful in e.g. the SILAC workflows of OpenMS. So maybe we should come up with a solution. E.g. a (last processing) node dependent suffix/prefix/folder like in TOPPAS. We could add something in the config dialogue to let the user choose and default to something fixed like a node index.

jpfeuffer commented 7 years ago

Hm actually you could probably do some flowvariable magic while iterating over the merged list in the loop and parsing the URI but that's quite advanced.

jpfeuffer commented 7 years ago

And I saw that you could actually use Output Files for this, which already appends a number to the file names. Still.. there should be a warning