search

genericworkflownodes / GenericKnimeNodes

Base package for GenericKnimeNodes
https://github.com/genericworkflownodes/GenericKnimeNodes
Other
15 stars 16 forks source link

Fix icons and categories #204

Closed AlexanderFillbrunn closed 6 years ago

AlexanderFillbrunn commented 6 years ago

2 things are made better in this PR:

  1. Categories of dynamically generated versioned nodes are now top-level, so that we have /version/ instead of //version

  2. Implementers of the DynamicGenericNodeFactory now have access to the tool name for resolving the icon and if the icon is not there, it is set to an empty string.

jpfeuffer commented 6 years ago

Looks good. Ready to merge from your side?

AlexanderFillbrunn commented 6 years ago

Yes, ready!