search

genericworkflownodes / GenericKnimeNodes

Base package for GenericKnimeNodes
https://github.com/genericworkflownodes/GenericKnimeNodes
Other
15 stars 16 forks source link

Added a new flag, ignoreUnusedParameters. #208

Closed chahuistle closed 6 years ago

chahuistle commented 6 years ago

In the very specific case of exporting KNIME workflows, the CTD configuration is also exported. For this, each node configuration is cloned by writing the configuration (via CTDConfigurationWriter) and then reading it back again using CTDConfigurationWriter.

This scenario requires all parameters to be written, otherwise, IndexOutOfBoundsExceptions are bound to happen.

chahuistle commented 6 years ago

Oh no. Jenkins, please.

chahuistle commented 6 years ago

So, to elaborate a bit more on why I added this seemingly useless flag, take a look at this change: https://github.com/genericworkflownodes/GenericKnimeNodes/commit/d82b68163d04a06c149341107b7b1b1a7b92e203 .

My change makes d82b68163d04a06c149341107b7b1b1a7b92e203 backwards compatible. Today was one of those days where I gathered courage to actually git pull.