search

genericworkflownodes / GenericKnimeNodes

Base package for GenericKnimeNodes
https://github.com/genericworkflownodes/GenericKnimeNodes
Other
15 stars 16 forks source link

[FIX:#237] Fixes the command generation for list parameters. #238

Closed rrahn closed 5 years ago

rrahn commented 5 years ago

Fixes #237

In this fix the CommandLineGenerator treats each command line value as a separate list. Thus later on when expandingCommands is invoked each value can be prefixed with the list option name.

Note

The question remains, whether the the first option given in #237 was intended. If this was intentional we need another solution such that depending on the node model either the first option or the second option for the parameterlist command generation can be choosen.

rrahn commented 5 years ago

@jpfeuffer I changed the PR according to our discussion. It now uses the isList value in the expandParameter function to trigger different expansions.

jpfeuffer commented 5 years ago

Nice. Could you test it already?

rrahn commented 5 years ago

Yes I tested it with seqan_tcoffe node.