genericworkflownodes / GenericKnimeNodes

Base package for GenericKnimeNodes
https://github.com/genericworkflownodes/GenericKnimeNodes
Other
15 stars 16 forks source link

Remove unnecessary dependencies #274

Open jpfeuffer opened 4 years ago

jpfeuffer commented 4 years ago

E.g. I recently removed apache.commons.text / apache.commons.lang3.text from IndexLoader since the methods are either deprecated or the packages are not shipped in the knime update site anymore. Options: 1) check how knime does it now 2) think about if really needed (here: system property substitution in file paths) and remove/comment out (currently done). Commit 8a7955c5736cb1d83406e3cd3220ce3cb361f969 and related 3) write your own 4) use/inherit from knime classes properly or ask for an API