genesis-community / concourse-genesis-kit

A Genesis Kit for Concourse CI/CD
MIT License
6 stars 13 forks source link

The kit only support org with all the team for github oauth by default #21

Closed xiujiao closed 6 years ago

xiujiao commented 6 years ago

The github-oauth subkit only allow us to configure one org with team all during genesis new. If we would like to configure different orgs with different team permission or use users , we have to do something like this in the env yml file.

instance_groups:
  - name: web
    jobs:
    - name: atc
      properties:
        github_auth:
          authorize:
            - (( replace ))
            - user: xiujiao
jhunt commented 6 years ago

Any proposals on how to fix this, @xiujiao ?

xiujiao commented 6 years ago

@jhunt We could do something similar with what you did in shield, we just do not prompt detailed questions for orgs/team, instead of we provide a configuration example in READ me or Manual; the other option is that @dennisjbell Dennis did mention that we could make genesis/kit deal with array for this part

jhunt commented 6 years ago

Do we just need a param for authorizations?