genesis-community / concourse-genesis-kit

A Genesis Kit for Concourse CI/CD
MIT License
6 stars 13 forks source link

Remove unused parameters from CF OAuth addon. #51

Closed tjliebel closed 4 years ago

tjliebel commented 4 years ago

Remove the unused params uaa_token_url and uaa_auth_url from the CF OAuth addon. The data that these used to provide is now pulled from the cf_api_url endpoint by concourse. Also removed cf_token_uri which was cited in the manual, but did not exist in the kit.

Fixed the incorrect CF OAuth addon parameter cf_auth.ca_cert.certificate which was previously cf_auth.ca_cert.

thomasmitchell commented 4 years ago

https://github.com/concourse/concourse-bosh-release/blob/cc61b80bc163489abc5707ea5e6fc740b949b760/jobs/web/spec#L658

this property is deprecated now. change it to spaces_with_developer_role

tjliebel commented 4 years ago

Updated spaces to spaces_with_developer_role. Change was tested and cf oauth still worked as expected.

thomasmitchell commented 4 years ago

It's glorious