search

genesis-community / concourse-genesis-kit

A Genesis Kit for Concourse CI/CD
MIT License
6 stars 13 forks source link

feature to disable haproxy #52

Closed thomasmitchell closed 4 years ago

thomasmitchell commented 4 years ago

the no-haproxy feature does what it says, it removes the HAProxy node

For simplicity and consistency, this changes the listening port of the web node to 80 (from 8080) when not using TLS. This is consistent with TLS changing the backend port to 443, and also eliminates the requirement to do this override with an additional file when the no-tls feature is used in conjunction with this one.

This feature also shifts the static IPs of web nodes back one IP, into the spot where an HAProxy would be, such that you don't need two static IPs just to deploy one web node.

dennisjbell commented 4 years ago

As discussed, a more complete solution would be to provide for a vm_extension on web nodes and move to dynamic IP addresses to get away from the limit of 5 static IP addresses. However, there is a need for this change as-is for systems that don't use IaaS-provided LBs, and will work for IaaS-provided situations until such a time as a dynamic solution is forthcoming