genetic-tools / primerbench

0 stars 0 forks source link

Correctly handle M13 sequences #15

Closed GaretJax closed 6 years ago

GaretJax commented 6 years ago

See #11

Ok, that is not so satisfying. But I would guess it is unsafer to extract a sequence based on upper and lower case letter. Maybe it is safer to exclude all M13 sequences (by the user) before uploading the primer list. The alternative would be to specifiy the used M13 sequence, but I guess that is much more difficult.

GaretJax commented 6 years ago

@AnCaTjin what about offering the user the possibility to specify the M13 sequences in the import primer form? See an example below: image

(the field could even be prepopulated with the last sequences used on an import by the same user or lab)

AnCaTjin commented 6 years ago

That's what I meant above :) If it is not to difficult to implement, that would be the ideal solution. But I would suggest to keep the formulation more open. Other sequences might not (probably rare cases) be M13, as they derive from some other phage.

GaretJax commented 6 years ago

I'll implement it, is not too hard.

Suggestions about the formulation are welcome. ;-)

AnCaTjin commented 6 years ago

"common primer sequence (e.g. M13)"? "universal sequencing primer sequence"?

GaretJax commented 6 years ago

This should be fixed. You're welcome to take it for a spin: https://genetic.tools/labs/test/primers/imports/

GaretJax commented 6 years ago

Just to make sure: the common sequences are removed only from the start of the primer, not if they happen in the middle or at the end.

AnCaTjin commented 6 years ago

Yes, they are only at the start of a primer, however these sequences are used because they are supposed to be unique. They do not match anywhere in the human genome. Therefore they should not be part of any specific primer sequence.

AnCaTjin commented 6 years ago

I think I would prefer "universal primer sequence (e.g. M13) :)

GaretJax commented 6 years ago

Done.

GaretJax commented 6 years ago

I'll mark this one as solved. Feel free to add a comment if you think this needs further improvement.