Open pjotrp opened 7 years ago
Implemented points 1..5 in PR https://github.com/genetics-statistics/GEMMA/pull/73
@pjotrp That is a great summary. The cholesky factorization methods in most libraries has a check for a matrix being s.p.d. (symmetric positive definite), so you could use this to implement item 4.
1-4 have been implemented. 5 and 6 probably show up now as warnings.
GEMMA should give hints if matrix properties are invalid, such as discussed in https://github.com/genetics-statistics/GEMMA/issues/45#issuecomment-323524276. E.g.
@xiangzhou @pcarbo anything else we can think of?
Failures and warnings should be reported in the log file. These checks can be disabled with the --no-checks switch (i.e., dangerous mode but faster).