geneura-papers / 2015_books

Paper on the book publishing prediction
Artistic License 2.0
2 stars 0 forks source link

Revise "editorial" to "publisher" #23

Closed JJ closed 8 years ago

JJ commented 8 years ago

It's the most correct way of doing it.

unintendedbear commented 8 years ago

I've been reviewing where the "editorial" or "editor" words are and I found two main problems:

So, what can we do? :(

JJ commented 8 years ago

2016-04-28 14:07 GMT+02:00 Paloma de las Cuevas Delgado < notifications@github.com>:

I've been reviewing where the "editorial" or "editor" words are and I found two main problems:

  • In "Trevenque Editorial S.L.", that I guess is the Spanish name so it should remain as it is (because in Spanish it indeed is "Editorial").

That's OK

  • You named a parameter/feature "editorial". This is inconsistent with everything else I'm changing and I think is the reason why @7ossam81 https://github.com/7ossam81 said this morning that the two words are used in the paper.

So, what can we do? :(

If that word is not in the figures, change it. And if it is in figures, change the figures...

JJ

unintendedbear commented 8 years ago

Ok :D

unintendedbear commented 8 years ago

Re-assigning to @7ossam81 for review. I'm going to review the whole paper, anyways :)