search

genevieve / leftovers

Go cli & library for cleaning up orphaned IAAS resources.
Apache License 2.0
149 stars 22 forks source link

Update to ginkgo 2 #110

Closed Alphasite closed 1 year ago

Alphasite commented 1 year ago

Update from v1 to ginkgo v2

genevieve commented 1 year ago

@Alphasite What happens when you run ginkgo -r . against these changes?

genevieve commented 1 year ago

It looks like this MR might have removed all the imported ginkgo lines instead of updating them to v2 so I opened https://github.com/genevieve/leftovers/pull/112 but please let me know if I'm missing something.

Alphasite commented 1 year ago

Ah sorry, i think i messed up when i was trying to split it out into separate MRs. Your PR looks great though! The main branch of the fork worked fine, but I probably should have checked this more carefully.

genevieve commented 1 year ago

Ok great, closing in favor of #112