search

genevieve / leftovers

Go cli & library for cleaning up orphaned IAAS resources.
Apache License 2.0
150 stars 22 forks source link

update azure sdk will solve #106 #122

Closed ramonskie closed 1 year ago

ramonskie commented 1 year ago

updating the azure sdk. as the old sdk was not using go mod yet. which caused issues within our project where we also updated the azure sdk

i have not done any acceptance tests unfortunately as i do not have an azure account available to test it in.

fixes #106

genevieve commented 1 year ago

Hey @ramonskie, this looks good. Can you update the branch to rebase off main since the vendor dir and all were removed?

ramonskie commented 1 year ago

@genevieve cleaned it up and force pushed :)

genevieve commented 1 year ago

I don't currently have an azure account to test these changes out either but will try to get one soon to validate that the functionality here hasn't changed.

ramonskie commented 1 year ago

changed the acceptance to the new sdk as wel.

genevieve commented 1 year ago

Decided to merge since the changes follow their migration guide and I'll find a way to test this with some iaas creds before releasing a new version. Thank you for the PR!