genexu / react-native-pie-chart

Simple pie chart module for your React Native app
MIT License
109 stars 47 forks source link

Not a circle on Android after RN version 0.45.0-rc.0 #10

Closed EyreGe closed 6 years ago

EyreGe commented 7 years ago

5ed6189f8c1d0e826104ca1c74fd88aa

genexu commented 7 years ago

Hello @EyreGe, can you give me the props you input and package dependencies (or more), i need more information to check up this issue.

genexu commented 7 years ago

Because of there are no further comment, i decided to close this issue, if have any question or similar problem, plz give me a notice.

andrii-yarmola commented 7 years ago

same issue for android only (its ok for IOS) i used your examples "react-native": "0.45.1", npm 4.2.0 node 7.10.0

genexu commented 7 years ago

@andrii-yarmola i already verify this is an issue and working on to fix it, thanks for your report.

genexu commented 7 years ago

[Update] already confirm previous version (1.0.11) is fine (use https://github.com/genexu/react-native-pie-chart/tree/master/example to testing), also testing back to version 1.0.5 .

At version 1.0.12, i update the React Native dependency version and use PropTypes to Instead of React.PropTypes.

So, the problem probably is on React Native side, it need to take some time to find out the problem is happen on witch RN version.

If your are really need this module feature now, I recommend you to downgrade the RN version before it fixed.

genexu commented 7 years ago

Any body have this issue, plz share you package dependencies, and have a comment immediately when you discover this issue is be repaired.

genexu commented 7 years ago

[Update] react-native version check out result

RN 0.45.0 with react@16.0.0-alpha.12 - Bad RN 0.45.0-rc.2 with react@16.0.0-alpha.12 - Bad RN 0.45.0-rc.1 with react@16.0.0-alpha.12 - Bed RN 0.45.0-rc.0 with react@16.0.0-alpha.12 - Bed RN 0.44.3 with react@16.0.0-alpha.6 - Good RN 0.44.0 Good react@16.0.0-alpha.6 - Good

danstepanov commented 6 years ago

"react-native": "^0.46.1" and have this issue as well

genexu commented 6 years ago

@danstepanov thx for the report.

lelup commented 6 years ago

screen shot 2017-08-10 at 11 09 18 I have same issue on Android, my dependencies : { "react": "16.0.0-alpha.12", "react-native": "0.46.4", }.

zpp-gp commented 6 years ago

如果使用 RN 0.44.3 with react@16.0.0-alpha.6 采用这个版本1.0.12,Android 是可以正确的吗?

genexu commented 6 years ago

@zpp-gp That's right, RN 0.44.3 with react@16.0.0-alpha.6 version has been tested as well.

zpp-gp commented 6 years ago

谢谢,希望有时间可以解决高版本的兼容性问题,顶顶!

Selvamhibiz commented 6 years ago

@genexu My Application is getting closed while using Pie Chart but working fine in ios and my dependencies are "dependencies": { "react": "16.0.0", "react-native": "0.51.0", "react-native-pie-chart": "1.0.12" }, i also tried by changing dependencies to ("RN 0.44.3 with react@16.0.0-alpha.6" "RN 0.44.0 Good react@16.0.0-alpha.6") which you had mentioned in earlier comments.

But for Android it is not working. can you suggest me how to implement Pie Chart in my Project.

genexu commented 6 years ago

@Selvamhibiz Sorry for late reply, quite busy recently.

So, let me ensure first, your problem is application will be closed when use this package? that is not related with this issue, and i'm haven't this problem before. I need more information about this issue to find solve it.

Thanks for your response.

robertobrogi commented 6 years ago

Hi, I use this depen: "expo": "^23.0.4", "react": "16.0.0", "react-native": "0.50.3"

And i have the same problem in Andrios, ios work fine

ericrojo156 commented 6 years ago

I have observed the same issue. My dependencies are:

    "react": "16.0.0-alpha.12",
    "react-native": "0.49.5",
            "react-native-pie-chart": "~1.0.12"
geek6 commented 6 years ago

i have the same issue on Android, iOS fine. My dependencies are: "react": "16.0.0", "react-apollo": "^2.0.1", "react-native": "v0.52.0-rc.0", "react-native-pie-chart": "^1.0.12"

andreuccia commented 6 years ago

same Issue with:

"react": "16.2.0", "react-native": "0.51.0",

abbreviatedman commented 6 years ago

Not sure if it still helps to get dependencies, but! Same issue with:

"dependencies": { "prop-types": "^15.6.0", "react": "16.2.0", "react-native": "0.52.0", "react-native-pie-chart": "^1.0.12", }

Hope this helps!

genexu commented 6 years ago

Thanks for everyone who reported the status of this issue, it is always helpful.

RN ART libs seem was not be implement anymore, i'm plan to open another project for RN pie chart with SVG tech (may with other kind of chart, spilt to different module).

Still welcome the status report about this issue, a lot of thanks.

skicson commented 6 years ago

There is a workaround just for the pie chart - I haven't looked into it enough to figure out how to do the doughnut but looking at https://github.com/bgryszko/react-native-circular-progress/blob/master/src/CircularProgress.js would suggest it's doable.

Anyways, commenting out line 183 of Wedge.js and replacing with

//   return <Shape d={path} stroke={this.props.fill} strokeWidth={outerRadius} strokeCap='butt' />;
let size = this.props.outerRadius * 2;
let cx = cy = size/2;
let p = Path();
p.path.push(0, cx, cy);
p.path.push(4, cx, cy, outerRadius, startAngle * Math.PI / 180, endAngle * Math.PI / 180, 1);
return <Shape d={p} fill={this.props.fill} />;

seems to be working so far for me..

genexu commented 6 years ago

@skicson I was tried the similar code couple month ago, but it's not work. and i just try it again with newest version of RN and React, it work!!! Holy!!!, maybe it was fixed on one of version of RN.

I'm already publish new version of this module, plz update and have a test, thanks again.

If every is good, then i will close this issue.