Closed songquanpeng closed 3 years ago
Hello, I am confused why your implementation applies scaling operation after the convolution operation: https://github.com/genforce/interfacegan/blob/acec139909fb9aad41fbdbbbde651dfc0b7b3a17/models/stylegan_generator_model.py#L760
I have checked the official implementation: https://github.com/genforce/interfacegan/blob/acec139909fb9aad41fbdbbbde651dfc0b7b3a17/models/stylegan_tf_official/training/networks_stylegan.py#L527 Looks like they don't do this?
I have run your script and the result looks okay. Maybe you can offer some help with this? Thx in advance!
Okay, I found it: https://github.com/genforce/interfacegan/blob/acec139909fb9aad41fbdbbbde651dfc0b7b3a17/models/stylegan_tf_official/training/networks_stylegan.py#L142
Hello, I am confused why your implementation applies scaling operation after the convolution operation: https://github.com/genforce/interfacegan/blob/acec139909fb9aad41fbdbbbde651dfc0b7b3a17/models/stylegan_generator_model.py#L760
I have checked the official implementation: https://github.com/genforce/interfacegan/blob/acec139909fb9aad41fbdbbbde651dfc0b7b3a17/models/stylegan_tf_official/training/networks_stylegan.py#L527 Looks like they don't do this?
I have run your script and the result looks okay. Maybe you can offer some help with this? Thx in advance!