genielabs / HomeGenie

HomeGenie, the programmable automation intelligence
https://homegenie.it
GNU General Public License v3.0
393 stars 155 forks source link

Add passive automation device handling #107

Closed skl77 closed 9 years ago

skl77 commented 9 years ago

Purpose: Integrate some low cost devices, like Intertechno; Elro etc.

genemars commented 9 years ago

Hi thanks for this, but you're using deprecated property "Modules" in your mig interface. Also the following code https://github.com/genielabs/HomeGenie/pull/107/files#diff-60b26291cea88c31d88e0b6adb232660L1701 should not be there as it is too specific for this particular implementation. I know there are some files that still use cr/lf formatting, but this issue should not be carried out by your commit as these files are not touched by your interface implementation.

skl77 commented 9 years ago

Hi Gene, thanks for the feedback. Do you have an suggestion for me, how can i implement such an interface in permit way ?

genemars commented 9 years ago

Hi @skl77 thanks for this contribution. Can you please make the pull request only contain files that are strictly related to your interface additions? It is currently pushing a 24 files changes.

genemars commented 9 years ago

Hi @skl77 , MIG Interface Drivers can now be developed as stand-alone projects and can be bundled and shipped as a file that can be imported in HG for adding new interface drivers. Read this message, since this apply to you also: https://github.com/genielabs/HomeGenie/pull/142#issuecomment-93490333