search

genielabs / HomeGenie

HomeGenie, the programmable automation intelligence
https://homegenie.it
GNU General Public License v3.0
401 stars 157 forks source link

Sync #141

Closed ocalvo closed 4 years ago

ocalvo commented 9 years ago

Suspend insteon listener thread while performing device discovery to avoid closing the COM port if an exception occurs.

genemars commented 9 years ago

Hi ocalvo, this is not compiling with mono. It complains about different target framework. Since I am concerned about changing all projects to target 4.5, we've got to find a 4.0 compatible solution. Let me know your thoughts about that.

genemars commented 9 years ago

Changing HomeGenie project to target 4.5 it compiles without any error. Let's try this way. I will merge this later.

genemars commented 9 years ago

hi @ocalvo , I ended up trying a "soft" solution that does not require targeting changes. Can you please verify that it is working this way too?

ocalvo commented 9 years ago

I don't think so. I will cook another fix that does not require targeting changes.

We really need a way to resume/suspend the thread and abort is just not an option.

Sent from my Windows Phone

From: Genemailto:notifications@github.com Sent: ‎3/‎8/‎2015 7:34 AM To: genielabs/HomeGeniemailto:HomeGenie@noreply.github.com Cc: Oscar Calvomailto:oscar@calvonet.com Subject: Re: [HomeGenie] Sync (#141)

hi @ocalvo , I ended up trying a "soft" solution that does not require targeting changes. Can you please verify that it is working this way too?

Reply to this email directly or view it on GitHub: https://github.com/genielabs/HomeGenie/pull/141#issuecomment-77752187

genemars commented 9 years ago

ok @ocalvo , the best is that you do it because you can test it =) thanks!

genemars commented 9 years ago

is this working now from last HG source code?

ocalvo commented 9 years ago

Hi, I had no time to test the last version. I think it will not because we really need to stop the thread during discovery. I am in the process of moving to a brand new home, that's why I have not had any time to test the new code.(On the plus side, now I will be able to complete my dream of a fully automated home :) ) Sorry about the delay, Thanks and regards, Oscar CalvoDate: Wed, 15 Apr 2015 10:16:45 -0700 From: notifications@github.com To: HomeGenie@noreply.github.com CC: oscar@calvonet.com Subject: Re: [HomeGenie] Sync (#141)

is this working now from last HG source code?

— Reply to this email directly or view it on GitHub.

genemars commented 9 years ago

@ocalvo , hg is now targetting 4.5.