search

genielabs / HomeGenie

HomeGenie, the programmable automation intelligence
https://homegenie.it
GNU General Public License v3.0
395 stars 155 forks source link

Request: Add Zwave Devices #164

Closed HellStorm666 closed 1 year ago

HellStorm666 commented 9 years ago

Searched all json files with a script. Found a few devices that I want to use that aren't in the json files.

TKB-TZ65D (dimmer) Zwave.Me ZME-WallC-s (dimmer)

HellStorm666 commented 9 years ago

xml file for TKB-TZ65D http://www.pepper1.net/zwavedb/device/343/343-0118-0808-0808-06-03-28-01-03.xml

xml file for ZME-WallC-s http://www.pepper1.net/zwavedb/device/554/554-0115-0100-0101-03-03-5c-01-00.xml

genemars commented 9 years ago

https://github.com/genielabs/HomeGenie/blob/master/BaseFiles/Common/html/ext/zwave/pepper1db/0115_0100_0101.json

https://github.com/genielabs/HomeGenie/blob/master/BaseFiles/Common/html/ext/zwave/pepper1db/0118_0808_0808.json

g

HellStorm666 commented 9 years ago

https://github.com/genielabs/HomeGenie/blob/master/BaseFiles/Common/html/ext/zwave/pepper1db/0118_0808_0808.json is not correct. That is "productName": "TZ65S" while the xml is TZ65D

image from https://github.com/genielabs/HomeGenie/blob/master/BaseFiles/Common/html/ext/zwave/pepper1db/0115_0100_0101.json is not correct.

genemars commented 9 years ago

It seems that there are different products with same ID =/ http://www.pepper1.net/zwavedb/device/554/554-0115-0100-0101-03-03-5c-01-00.xml http://www.pepper1.net/zwavedb/device/562/562-0115-0100-0101-03-03-5c-01-00.xml so even if there were both json files, it would be hard to determine the correct one to pick. Any suggestion is welcome.

HellStorm666 commented 9 years ago

The TZ65D is only $5,- more than the TZ65S and gives the ability to dim instead of switch, but can also switch. The TZ65D is the most used therfore I guess. So dropping the TZ65S would be best I think.

Also, The TZ65S isn't showed at http://www.pepper1.net/zwavedb/ under manufacturer Wenzhou TKB Control System CO.,LTD

http://www.pepper1.net/zwavedb/device/562/562-0115-0100-0101-03-03-5c-01-00.xml also says keychain controller. and that is KFOB-S (http://www.z-wave.me/index.php?id=31) so a completly different product.

genemars commented 9 years ago

ok, added sorting by file name (asc) in the json file generator program, so among files with same ID, the latest should be generated.

HellStorm666 commented 9 years ago

Maybe including the device type (554 and 562 part) in the json could fix this problem. So the json wont be 0115_0100_0101.json but 554_0115_0100_0101.json and 562_0115_0100_0101.json

genemars commented 9 years ago

nevermind about sorting, 554 (the lowest) seem to be the one you need... anyway 554 and 562 is a counter field that cannot be derivated from the device data, so having this number in the file names will not help as is.

HellStorm666 commented 9 years ago

Maybe ask pepper1 how it is possible that there are 2 devices with the same ID. Should not be possible imho

genemars commented 9 years ago

it should not... pheraps the first one is out of production. so the problem is that the manufacturer should have changed the id of the latter product.

HellStorm666 commented 9 years ago

a well.... If you can't fix it, no problem. Then I will replace the json file myself offline when I have HG installed ;)