search

genielabs / HomeGenie

HomeGenie, the programmable automation intelligence
https://homegenie.it
GNU General Public License v3.0
393 stars 155 forks source link

Update thermostat.js #209

Closed mtanana closed 8 years ago

mtanana commented 9 years ago

Fixed some Fahrenheit issues on the thermostat. (Someone using Celsius might want to check this one out)

mtanana commented 9 years ago

Actually- don't accept this yet. I think the module has changed since the release I was working on.

mtanana commented 9 years ago

ok- Checked and it should be fine with the newer release

mtanana commented 9 years ago

I'm also working on fixing a bug in the status change for some thermostat messages. There is a cast class exception for the byte -> enum in the ZWave MIG. I think I have it figured out....

genemars commented 9 years ago

please if you're willing to work on ZWaveLib use the new repository as HG will be updated soon to use the new library. https://github.com/genielabs/zwave-lib-dotnet Much more easy to debug and work on zwave from its own project :) I will wait some more before merging this, in case you've got some updates.

mtanana commented 9 years ago

Ohh- didn’t see that you were revamping. Yeah- you can kick out this request and I’ll check out the new repository and put in a request there after I make sure it is compliant with the newer stuff.

From: Gene [mailto:notifications@github.com] Sent: Saturday, August 22, 2015 9:34 AM To: genielabs/HomeGenie Cc: mtanana Subject: Re: [HomeGenie] Update thermostat.js (#209)

please if you're willing to work on ZWaveLib use the new repository as HG will be updated soon to use the new library. https://github.com/genielabs/zwave-lib-dotnet Much more easy to debug and work on zwave from its own project :) I will wait some more before merging this, in case you've got some updates.

— Reply to this email directly or view it on GitHub https://github.com/genielabs/HomeGenie/pull/209#issuecomment-133715728 . https://github.com/notifications/beacon/AEmnkJ8V8VMoENEaly8TbdwS7EdLiAIIks5oqI38gaJpZM4Fumbv.gif