genielabs / HomeGenie

HomeGenie, the programmable automation intelligence
https://homegenie.it
GNU General Public License v3.0
388 stars 154 forks source link

1.2 wip #333

Closed genemars closed 5 years ago

genemars commented 5 years ago

Hey @Bounz is this still good?

Bounz commented 5 years ago

Hi. Looks like it's still good, as it brings Auto-restart of crashed programs and some fixes to the scheduler. One issue - in this PR new project for unit-tests was added HomeGenieTests, but in your recent changes, you have added HomeGenie.Tests project, so these projects should be merged.

Also, while you were away, I did a lot of refactoring in my hard-fork (sorry for doing this, but I was in despair and didn't know the probability of your returning) related to statistics (replaced SQLite with LiteDB), using NuGet packages instead of committing binaries to git, moving all user files into separate folder, prepared docker image and wrote install scripts that allow to install HG in one command. Take a look here for closed issues: https://github.com/Bounz/HomeGenie-BE/issues?q=is%3Aissue+is%3Aclosed and here for information about releases: https://homegenie.club/t/version-1-1-15-released/199 https://homegenie.club/t/v1-1-18-released-for-testing-purposes-only/363 https://homegenie.club/t/v1-1-19-released-for-testing-purposes-only/386

Maybe you will want to incorporate some of these changes.

genemars commented 5 years ago

@Bounz, I'm currently migrating everything to automatic build system and automatic publishing. This repos also has now automatic build and release publishing.

Travis Build Status Build status

Of course I'd like to integrate everything can be integrated from your fork as well.

Right now I'm getting rid of all static references in HomeGenie and moving most of them to nuget.