search

genielabs / HomeGenie

HomeGenie, the programmable automation intelligence
https://homegenie.it
GNU General Public License v3.0
388 stars 154 forks source link

OpenWeather in Metric only Except Temp #376

Closed LostDog88 closed 1 year ago

LostDog88 commented 5 years ago

Expected behavior

Report wind in Imperial measurement not metric.

Actual behavior

Unable to change setting.

Steps to reproduce the problem starting from a fresh install

Specifications

Additional configuration notes

tuicemen commented 5 years ago

Since it appears your only using version 1.1-stable.527 the JKUtilsOpenWeather is a addon. It is highly unlikely the JKUtilsOpenWeather addon will be updated in the package manager

However Version 1.2-stable.39 and newer have OpenWeatherMap which replaces Weather Underground. @genemars maybe able to explain how to switch that program to use and display imperial units or add it as an enhancement if not possible currently. You might consider updating to the latest HG for that and other enhancements.

tuicemen commented 5 years ago

@LostDog88 I've been looking at what OpenWeatherMap is being asked for by HG. and what can be asked for. @genemars currently has metric measurements hard coded in though it is possible to retrieve the actual values in imperial or metric measures. I doubt your open to playing with the Openweather code as any customization to it would be lost on a Update without reinstalling a backup after each update. However viewing the API call options here https://openweathermap.org/current you can figure out what to change in the code yourself just make a backup prior to playing.

tuicemen commented 5 years ago

@LostDog88 I decided to play with switching the values to imperial and was able to get the values to display correct Temperature shows in the top bar on the group page but the widget still doesn't display the ℉ . This can be fix by switching the Unicodes ℃ in the Widget Java section with ℉ Now the unfortunate part for me is HG still sees the ℉ value and not the ℃ values. I can fix this in the widget but have not dug into the HG code to see what the issue is with the value reported in the UI (top right corner). Hopefully the next update will address this.

tuicemen commented 5 years ago

@LostDog88 I believe I have all metric/imperial displays worked out. Fixes are outlined in #382 perhaps you can test them out and if they work for you this issue can be closed. I've also put in a pull request so enhancements can be added to the next HG build once reviewed #388