genielabs / HomeGenie

HomeGenie, the programmable automation intelligence
https://homegenie.it
GNU General Public License v3.0
392 stars 155 forks source link

GetDateEndianType does not necessarily correlate to Fahrenheit usage #92

Closed tareko closed 9 years ago

tareko commented 9 years ago

After being very annoyed by why I can't get rid of fahrenheit, I discovered that HG makes a silly assumption. From /BaseFiles/Common/html/pages/control/widgets/homegenie/generic/thermostat.json

if (HG.WebApp.Locales.GetDateEndianType() == 'M') displayUnit = 'Fahrenheit';

At least in Canada, this is definitely not true.

Can this not be a user-specified option that defaults to the international standard of Celsius??

For me, I fixed this problem by simply doing:

grep -R "GetDateEndianType" * | grep "Fahrenheit"

and then removing all of the instances.

tarek : )

genemars commented 9 years ago

a user-specified option would be a good solution. mark this as enhancement.

gitbjo commented 9 years ago

Hi,

I agree, this should be a setting for the widget. I have the same problem in Switzerland.

Therefore I would say it should be marked as Bug.

gitbjo.

genemars commented 9 years ago

duplicate #196