search

geniiii / FarLands

Far Lands in 1.14+
MIT License
17 stars 9 forks source link

Coordinate scale modification does not seem to move selector noise #19

Closed muzikbike closed 4 years ago

muzikbike commented 5 years ago

I've been doing a bit of messing around lately, and I've noticed that the farther lands always seem to initiate at the default 1004065920 regardless of whatever value is set in the far lands settings.

2019-09-09_01 16 39 2019-09-09_01 16 45 2019-09-09_01 20 12 2019-09-09_01 20 20

This made me think that the noise generator that causes the farther lands to happen, known to CubicWorldGen as selector noise, is not being moved along with the other noise generators.

To confirm my suspicions I decided to move the normal Far Lands super far away and teleporting to the usual farther lands point, and this resulted in terrain that very closely resembled my late 2018 cubicworldgen experiments with making selector noise overflow before normal far lands.

2019-09-09_01 22 01 2019-09-09_01 22 22

This bug does bring up an exciting prospect - it could be possible for selector noise to be made configurable completely independently of the other noise values responsible for conventional far lands, just like what is the case in the cubic chunks mod. I think this would be great.

geniiii commented 5 years ago

seeing this has made me realize that i accidentally left the estimates uneditable (which is why they're gray) after testing some code! whoops.. the joys of programming at 3am with 3 hours of sleep..

muzikbike commented 4 years ago

Should this be resolved in favour of #39?

geniiii commented 4 years ago

Should this be resolved in favour of #39?

sure

muzikbike commented 4 years ago

was wondering, since making this noise generator independently adjustable seems as though it would be easier than resolving that bigger ticket overall