Certain particles still use incorrect floats

geniiii / FarLands

Far Lands in 1.14+

MIT License

17 stars 9 forks source link

Certain particles still use incorrect floats #9

Closed muzikbike closed 4 years ago

muzikbike commented 5 years ago

Found to affect the following:

/particle particles
Particles from breaking armour stands
Particles from falling
Particles from damaging a mob
Particles from sweep attacks

geniiii commented 5 years ago

i know about these; the issue is that i'd need to rewrite the particle packet to fix them, which isn't a very good thing to do when it comes to compatibility, lol

muzikbike commented 5 years ago

Particles from adding eyes to end portal frames also lose precision:

2019-09-08_18 37 40

muzikbike commented 5 years ago

I've found a few more examples of particles losing precision; let me know if any of these seem reasonably fixable so I can open an issue for them.

Particles from activated conduits
Particles from end gateways
Particles from fishing (both splashes and moving fish thing)
Squid ink particles

geniiii commented 4 years ago

end gateway particles should be fixed in fb5c0735fa34d5b624964f33f980966bccab0b77
another i've found: campfire particles

muzikbike commented 4 years ago

Conduit and end gateway particles will be fixed in the next vanilla prerelease

muzikbike commented 4 years ago

Almost all of them are fixed in pre4. All I can find that still exist are bone meal and eye of enderortal frame addition particles. They also fixed tnt and enchanting tables.

muzikbike commented 4 years ago

Since there's so few of them currently in the game now I'll probably close this ticket and create individual tickets here instead

muzikbike commented 4 years ago

Closing this ticket until a playable version for 1.15 or 1.16 comes out, so then I can report any cases I find individually. Having a bunch of random particle bugs in one issue just causes clutter.