Closed 4TT1L4 closed 10 months ago
We are getting there, but https://github.com/geniusyield/smart-order-router/pull/48 did not solve the issue.
Now we are getting a different error message in the repository forks: https://github.com/4TT1L4/smart-order-router/actions/runs/6768359183
buildx failed with: ERROR: invalid tag "ghcr.io/4TT1L4/smart-order-router:latest": repository name must be lowercase
It turns out that the docker/metadata-action action can handle repository naming.
We just need to use it.
Implemented in the following PR:
Now the build is working in the fork repositories, but the image tagging is a bit off.
I have created a new fix to tag the images build from main with latest:
Now the tagging is also working. The image build from the main branch is tagged with latest.
We might need a more sophisticated tagging and release process in the future, but for now the bare minimum should be fine.
I have tested this in my own fork of the repository: https://github.com/4TT1L4/smart-order-router/pkgs/container/smart-order-router
See the following GitHub Actions run for details: https://github.com/4TT1L4/smart-order-router/actions/runs/6782570186
Problem:
Solution: