genkgo / camt

PHP Parser for CAMT messages
MIT License
81 stars 67 forks source link

Add organisation id for related parties and add proprietary amount #141

Open marac990 opened 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #141 (81c9f2b) into master (211c757) will increase coverage by 0.01%. The diff coverage is 84.61%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
+ Coverage     83.06%   83.07%   +0.01%     
- Complexity      663      668       +5     
============================================
  Files            78       78              
  Lines          1612     1625      +13     
============================================
+ Hits           1339     1350      +11     
- Misses          273      275       +2     
Impacted Files Coverage Δ
src/Decoder/EntryTransactionDetail.php 98.38% <60.00%> (-1.07%) :arrow_down:
src/DTO/Creditor.php 100.00% <100.00%> (ø)
src/DTO/Debtor.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

marac990 commented 1 year ago

Hi, regarding this I've added a real TxDtls from the statement that we receive from the bank (of course real data is changed for some dummy data). And in our case we need that parsed.

orukaz commented 1 year ago

Yes, Related Parties and ID-s are very neede, maybe I can help with that:

<RltdPties>
                            <Dbtr>
                                <Nm>Some person</Nm>
                                <Id>
                                    <PrvtId>
                                        <Othr>
                                            <Id>12345678</Id>
                                            <SchmeNm>
                                                <Cd>NIDN</Cd>
                                            </SchmeNm>
                                        </Othr>
                                    </PrvtId>
                                </Id>
                            </Dbtr>
<RltdPties>
                            <Dbtr>
                                <Nm>Business Ltd</Nm>
                                <Id>
                                    <OrgId>
                                        <Othr>
                                            <Id>675675676</Id>
                                            <SchmeNm>
                                                <Cd>COID</Cd>
                                            </SchmeNm>
                                        </Othr>
                                    </OrgId>
                                </Id>
                            </Dbtr>