genkgo / camt

PHP Parser for CAMT messages
MIT License
81 stars 68 forks source link

[TASK] Add support for `052.001.08` and `053.001.08` #145

Closed sbuerk closed 1 year ago

sbuerk commented 1 year ago

Same read capabilities are ensured like the versions before. Some new entities and attributes are missing and can be implemented in a dedicated change.

Resolves: #142 Related: #124 Related: #126

codecov-commenter commented 1 year ago

Codecov Report

Merging #145 (4b6dcc1) into master (08fd5f6) will increase coverage by 0.04%. The diff coverage is 85.71%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##             master     #145      +/-   ##
============================================
+ Coverage     83.06%   83.10%   +0.04%     
- Complexity      663      672       +9     
============================================
  Files            78       81       +3     
  Lines          1612     1640      +28     
============================================
+ Hits           1339     1363      +24     
- Misses          273      277       +4     
Impacted Files Coverage Δ
src/Camt052/MessageFormat/V08.php 83.33% <83.33%> (ø)
src/Camt053/MessageFormat/V08.php 83.33% <83.33%> (ø)
src/Camt052/Decoder/V08/Message.php 100.00% <100.00%> (ø)
src/Config.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sbuerk commented 1 year ago

Hope, this is okay so far. If I missed something, let me know.

sbuerk commented 1 year ago

@PowerKiKi Any change that this get's reviewed the next days and eventually a new version released ?

It's just for the planning, as we need to backport this library afterwards to be PHP5.6 compat again - but we have a deadline given by the bank.

Any thing I missed or need to change ?

sbuerk commented 1 year ago

ping

PowerKiKi commented 1 year ago

Merged as 15f3d03f60ac88a0e49feec611d8343cd5aed4f9, which is exactly the same but with test/data/camt052.v6.xml reverted as suggested by Frederik.

Released as 2.5.0.